Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Chunking Algorithm #4019

Closed
dragotin opened this issue Oct 28, 2015 · 10 comments
Closed

Implement new Chunking Algorithm #4019

dragotin opened this issue Oct 28, 2015 · 10 comments
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker Performance ReadyToTest QA, please validate the fix/enhancement technical debt
Milestone

Comments

@dragotin
Copy link
Contributor

dragotin commented Oct 28, 2015

There is a new chunking algorithm described here:
https://dragotin.wordpress.com/2015/06/22/owncloud-chunking-ng/
which is implemented for the server here:
owncloud/core#20118

This needs to be implemented in the client.

@dragotin dragotin added this to the backlog milestone Oct 28, 2015
@moscicki
Copy link
Contributor

Hi, other options expressed in the comments on the blog post are still considered?

@dragotin dragotin modified the milestones: 2.2.0-current, backlog Feb 18, 2016
@dragotin dragotin added the p2-high Escalation, on top of current planning, release blocker label Feb 18, 2016
@dragotin
Copy link
Contributor Author

According to #4342 this is a gold ticket.

@moscicki
Copy link
Contributor

@dragotin: for how long old chunking will be supported for compatibility with older server versions?

Also, I think it would make sense to write up the details in the style of https://github.com/cernbox/smashbox/blob/master/protocol/protocol.md so that we can catch any potential inconsistencies or issues before it is actually fully implemented. What do you think about it? Would you be willing to start this doc (can be in a separate file)?

@dragotin
Copy link
Contributor Author

Is not going to happen in 2.2.0 as the server API is not merged.

@dragotin dragotin removed this from the 2.2.0-current milestone Feb 23, 2016
@dragotin dragotin removed the p2-high Escalation, on top of current planning, release blocker label Feb 23, 2016
@guruz
Copy link
Contributor

guruz commented Mar 3, 2016

Tagging as "Performance" because we will implement automatic chunk size scaling for #4354

@rullzer rullzer added this to the 2.3.0 milestone May 20, 2016
@dragotin dragotin added the p2-high Escalation, on top of current planning, release blocker label May 20, 2016
@guruz guruz assigned ogoffart and unassigned dragotin May 20, 2016
@dragotin
Copy link
Contributor Author

Also consider to do dynamic chunk sizes as described in #4875 and #4354

@dragotin dragotin assigned dragotin and unassigned ogoffart May 20, 2016
@guruz guruz added the ReadyToTest QA, please validate the fix/enhancement label Nov 15, 2016
@guruz
Copy link
Contributor

guruz commented Nov 15, 2016

This was done as part of #5102

@guruz
Copy link
Contributor

guruz commented Jan 3, 2017

I wonder if it not just makes sense to merge the server side PR to check the checksums while uploading. But it is closed server side -> owncloud/core#26582

We don't have good test coverage for this currently..

So I still vote for having chunking ng only if the server checks checksums.. :/

FYI @ogoffart @SamuAlfageme @PVince81

@guruz guruz mentioned this issue Jan 3, 2017
@guruz
Copy link
Contributor

guruz commented Feb 15, 2017

The situation looks better now as @ogoffart @ckamm and @jturcotte tested chunking NG a lot.
@ogoffart is in progress of running the smashbox tests
And @IljaN is implementing checksum verification for 10.0 :)

@SamuAlfageme
Copy link
Contributor

@guruz we can leave this one open until both, the smashbox results and the checksum capabilities, are available since those would contribute to "formally" prove chunking is working. For now, as said, I didn't noticed any bugs regarding this.

@guruz guruz closed this as completed Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker Performance ReadyToTest QA, please validate the fix/enhancement technical debt
Projects
None yet
Development

No branches or pull requests

6 participants