Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for symbolic links or bogus filenames #4064

Closed
cdamken opened this issue Nov 3, 2015 · 21 comments
Closed

Warning for symbolic links or bogus filenames #4064

cdamken opened this issue Nov 3, 2015 · 21 comments

Comments

@cdamken
Copy link
Contributor

cdamken commented Nov 3, 2015

As we know, the client does not sync all files (for instance: no symbolic links or files with the following symbols: : ; ? * " > < | in file-name). However, if symbolic links are not synced, the systray icon remains green (see status-incorrect1.jpg).
Also within the Settings it says: Syncing selected files in your account with "name of the cloud" (shown as synced). This is confusing since not all the files that the user tried to sync are actually synced.

Advanced users are able to find this out via the activity screen, but the majority of users will just assume that there files are all synced and will perceive ownCloud as unstable when they miss certain files.
Therefore, we would like to see some kind of error message or warning to users who try to sync files that cannot be synced due to build-in restrictions.

@MorrisJobke

00004066

@MorrisJobke
Copy link
Contributor

@jancborchardt Any good idea how to communicate this to the user?

@cdamken
Copy link
Contributor Author

cdamken commented Nov 3, 2015

IMO, a different icon could be shown in the folder and pop-up a window or switch to activity tab where the warning are shown... but I'm not the expert.

@dragotin
Copy link
Contributor

dragotin commented Nov 3, 2015

In the beginning, there was a little warning sign in the tray icon to indicate that there were warnings. But that I had to remove to not annoy people. The current state of how it is is the result of long discussions.

@guruz guruz changed the title Warning for simbolic links Warning for symbolic links Nov 3, 2015
@guruz
Copy link
Contributor

guruz commented Nov 3, 2015

Related:
#3902

@guruz guruz changed the title Warning for symbolic links Warning for symbolic links or bogus filenames Nov 3, 2015
@guruz
Copy link
Contributor

guruz commented Nov 3, 2015

@cdamken Is this specifically about 2.0 ? Because there was also a change with regards to symbolic links on Windows, maybe this is the actual root cause?

@cdamken
Copy link
Contributor Author

cdamken commented Nov 5, 2015

I'll ask

@dragotin
Copy link
Contributor

dragotin commented Nov 6, 2015

related: #4083

@cdamken
Copy link
Contributor Author

cdamken commented Nov 10, 2015

@guruz

@cdamken Is this specifically about 2.0 ? Because there was also a change with regards to symbolic links on Windows, maybe this is the actual root cause?

Same behaivor with 1.8.4

The customer experience:

I just re-installed 1.8.4, but I got the same issue (see enclosure). In
addition, it is on Mac. The main problem here is that the message the
client gives is not wrong, but user-unfriendly: It does not indicate
that syncing went wrong (incomplete due to symbolic links and / or other
symbols).

Only if you go to the activity tab you notice (if you have luck to see it after a large list) that it says symlinks are not supported.

@MorrisJobke
Copy link
Contributor

@jancborchardt Can you have a look at this use case UX wise? Thanks :)

@guruz
Copy link
Contributor

guruz commented Nov 17, 2015

Easiest would be to merge it with the unsynced-items from #4083 (comment)

I'd also recommend to switch the default tab to the "Activity" tab..

@dragotin
Copy link
Contributor

Please check 2.1.0 beta1 if that fits the needs.

@cdamken
Copy link
Contributor Author

cdamken commented Dec 3, 2015

The changes look fine, I will confirm it with the customer and I let you know.

Thanks

@cdamken
Copy link
Contributor Author

cdamken commented Dec 10, 2015

No new comments from the customer. @guruz you can close the ticket if you want

@guruz guruz added this to the 2.2-nextminor milestone Dec 14, 2015
@cdamken
Copy link
Contributor Author

cdamken commented Dec 14, 2015

@guruz The customer reopen the issue:

I discussed it with a colleague and we were wondering if instead of
'activity --> server activity' you could make 'activity --> not synced'
the home-screen? With SURFdrive we have 'server activity' disabled so
this screen for us not of any use. In addition, users will click mostly
on this to verify if the sync worked correctly. Therefore, for us,
'activity --> not synced' would be the preferred home-screen.

If the Activity app is disable, the sync client should not show the tab, or better, the local activity.

@guruz
Copy link
Contributor

guruz commented Dec 14, 2015

@cdamken Do they also want the "Activity" menu bar entry on the top as the default? (vs having the sync folder selective sync & progress) as home?
2.1.1 or 2.2?

@dragotin
Copy link
Contributor

I agree that if there is no account having the activities enabled, we should not show the Activity tab. However, if activities are enabled on the server, the tab should appear magically.

@MTRichards
Copy link

Back to the top on these issues, does the client recognize a symbolic link and ignore it? @dragotin @danimo

This would qualify to me as a red x for these files (since they did not sync) and then they show up in the sync issue tab.

@cdamken
Copy link
Contributor Author

cdamken commented Feb 19, 2016

@cdamken Do they also want the "Activity" menu bar entry on the top as the default? (vs having the sync folder selective sync & progress) as home?
2.1.1 or 2.2?

The activity app is disabled in the server and the activity tab does not show what happens locally. It would be good to know, if the server activity app is not available or installed, that the client provided the information what is the client doing .

@dragotin
Copy link
Contributor

Sure, symbolic links are ignored as they always were. And that is mentioned in the not synced tab of course.

@cdamken If the activity app is not enabled, it says so in the client on the empty activity. The sync activity tough is in the tab with the same name.

@cdamken
Copy link
Contributor Author

cdamken commented Feb 22, 2016

@dragotin Thanks.

@guruz guruz assigned dragotin and unassigned MTRichards Apr 6, 2016
@dragotin
Copy link
Contributor

nosynced

We also show the number of the not synced items in the tab in 2.2.0. So I think this is fine. Please reopen if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants