Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check doctrine-dbal post-2.5.0 fixes #13071

Closed
AdamWill opened this issue Jan 1, 2015 · 3 comments
Closed

Check doctrine-dbal post-2.5.0 fixes #13071

AdamWill opened this issue Jan 1, 2015 · 3 comments

Comments

@AdamWill
Copy link
Contributor

AdamWill commented Jan 1, 2015

FWIW, in doing some preliminary testing of OC 8 for Fedora, I noticed that some of the post-2.5.0 commits on the 2.5 doctrine-dbal branch upstream look pretty significant, e.g.:

doctrine/dbal@8dadeb7
doctrine/dbal@21a2bf6
doctrine/dbal@aac6533 (and the three subsequent commits)

For my tests instead of building a package of dbal 2.5.0 I built one for the current tip of the 2.5 branch, so far that seems to be working well.

I can't say for absolute certain whether any of these issues affect ownCloud, but it seems like it'd be a good idea for someone with greater familiarity with the database stuff to check?

@DeepDiver1975
Copy link
Member

doctrine/dbal@8dadeb7

Not relevant for ownCloud as we don't use foreign keys and renaming indexes is not used (generally speaking)

doctrine/dbal@21a2bf6

hmmm - might be of interest - requires setup testing on PostgreSQL (especially creation of database) @jnfrmarks

doctrine/dbal@aac6533 (and the three subsequent commits)

Needs a second look - cannot judge right away

@AdamWill
Copy link
Contributor Author

AdamWill commented Jan 1, 2015

I should be able to test initial deployment and upgrade from 7.x with pgsql at least, I'll let you know how that goes.

@DeepDiver1975
Copy link
Member

8.0.2 ships doctrine 2.5.1 -> closing

@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants