File Comments Web Client Representation

[blizzz]

Contributes to #16328

• will be part of Timeline tab (Files Activity timeline tab containing comments, versions and activities #20259)
• flat list first, but hierarchy will be kept to be able to change this
• plain text only (in the future, nudging users via @-notation should be possible with this)
• after loading, unread comments should be marked as read
• not shown on public page

@nickvergessen @blizzz @DeepDiver1975 @jancborchardt

[nickvergessen]

flat list first, but hierarchy will be kept to be able to change this

had a short discussion in the office here. This will be a nightmare on sorting. Get the last 3 comments, what happens when the parent does not exist in this set of 3 items, how do we display them? What happens when the number of parents is 1000 (all nested), etc....

Just skip it for now.

not shown on public page

Also applies to federated shares then?

[blizzz]

not shown on public page

Also applies to federated shares then?

Federated shares are not public per se. If we can get it working without much trouble I think it is worth to show them in this case as well. Other opinions?

[nickvergessen]

Well we have a different set of user's.
I see @mentions flying to randomly and wrong users and also the current user is empty and unidentifyable: #13739

[jancborchardt]

Federated shares are comparable more to internal shares than public shares I’d say. For federated shares I’d definitely expect the comments to show.

Not necessarily something for the first step of course – but from a product design standpoint I’m always wary of introducing features which don’t work everywhere as expected (on mobile as well for example). Since we advertise federated sharing, and will advertise comments as well, comments should work for federated shares.

And just as a nice background read: How to display threaded discussions on the web
We’ll do a flat list first though.

[PVince81]

@blizzz have a look at system tags implementation to see how to define Webdav-compatible backbone collections:

core/core/js/systemtags/systemtagscollection.js

Line 27 in 6cb95f4

sync: OC.Backbone.davSync,

The dav properties mapping is done inside the model:

core/core/js/systemtags/systemtagmodel.js

Line 29 in 6cb95f4

davProperties: {

(if you want it, it's more convenient)

Also: need to figure out how to make it easier to do a Webdav REPORT call from JS. (I'll have a look at this)

[PVince81]

Comments have been implemented.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.