Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the uid on hover for sharing autocomplete #22611

Merged
merged 2 commits into from
Feb 25, 2016
Merged

Conversation

nickvergessen
Copy link
Contributor

Steps

  1. Add user1 with display name user
  2. Add user2 with display name user
  3. Try to share with user1

Expected

Users are distinguishable in the share dropdown

This adds a title to the inputs, so you can hover them to see the uid. The same is already the case for the share rows, so that could potentially resolve #20291

cc @PVince81 @MorrisJobke @rullzer

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @rullzer, @blizzz and @PVince81 to be potential reviewers

@MorrisJobke
Copy link
Contributor

Tested and works 👍

so that could potentially resolve #20291

I would rate this as a quick fix until we have a proper solution in place. It definitely helps to distinguish users. But it only reveals the internal representation and not something like the email address, which is better known.

@PVince81
Copy link
Contributor

Works, but did not use the correct style.

I pushed a commit to make both the autocomplete and the sharee row use the black tooltip way.
Please retest.

@PVince81
Copy link
Contributor

@MorrisJobke @nickvergessen @jancborchardt do you agree with my changes ?

👍 for @nickvergessen's changes.

Needs a second thumbs up for my commit 1add45a

@rullzer @schiesbn

@rullzer
Copy link
Contributor

rullzer commented Feb 25, 2016

👍

DeepDiver1975 added a commit that referenced this pull request Feb 25, 2016
Add the uid on hover for sharing autocomplete
@DeepDiver1975 DeepDiver1975 merged commit 3542310 into master Feb 25, 2016
@DeepDiver1975 DeepDiver1975 deleted the add-uid-on-hover branch February 25, 2016 15:55
@nickvergessen
Copy link
Contributor Author

👍

@lock
Copy link

lock bot commented Aug 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Share] It´s not possible to distinguish with whom you have shared something
6 participants