Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

php7 #1300

Merged
merged 2 commits into from
Feb 24, 2016
Merged

php7 #1300

merged 2 commits into from
Feb 24, 2016

Conversation

ChristophWurst
Copy link
Contributor

woohoo! finally! we're compatible with php7 💃

replaces #1262, #1265
fixes #1050

@mrubinsk thanks a lot for releasing the horde packages :-)

@owncloud/mail @clementhk review/test/celebrate please

@@ -366,20 +367,20 @@
},
{
"name": "pear-pear.horde.org/Horde_Nls",
"version": "2.1.0",
"version": "2.0.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks suspicious

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this happens because 2.0.3 is the highest version which allows php7 (from a composer.json perspective)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this. Even if a specify ^2.1.0@stable in composer.json, which is the lastest version here, 2.0.3 is installed :-/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the pear composer integration has some limitations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horde Nls 2.1.1 will support php7, 2.1.0 doesn't

./composer.phar require "pear-pear.horde.org/Horde_Nls"
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Initializing PEAR repository http://pear.horde.org
Using version ^2.1 for pear-pear.horde.org/Horde_Nls
./composer.json has been updated
Loading composer repositories with package information
Initializing PEAR repository http://pear.horde.org
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for pear-pear.horde.org/horde_nls ^2.1 -> satisfiable by pear-pear.horde.org/Horde_Nls[2.1.0].
    - pear-pear.horde.org/Horde_Nls 2.1.0 required php <6.0.0.0 -> your PHP version (7.0.3) or value of "config.platform.php" in composer.json does not satisfy that requirement.
  Problem 2
    - pear-pear.horde.org/Horde_Date 2.2.0 requires pear-pear.horde.org/horde_nls <3.0.0.0 -> satisfiable by pear-pear.horde.org/Horde_Nls[2.1.0].
    - pear-pear.horde.org/Horde_Date 2.2.0 required pear-pear.horde.org/horde_nls <3.0.0.0 -> satisfiable by pear-pear.horde.org/Horde_Nls[2.1.0].
    - pear-pear.horde.org/Horde_Date 2.2.0 requires pear-pear.horde.org/horde_nls <3.0.0.0 -> satisfiable by pear-pear.horde.org/Horde_Nls[2.1.0].
    - pear-pear.horde.org/Horde_Nls 2.1.0 required php <6.0.0.0 -> your PHP version (7.0.3) or value of "config.platform.php" in composer.json does not satisfy that requirement.
    - Installation request for pear-pear.horde.org/horde_date ^2.2.0@stable -> satisfiable by pear-pear.horde.org/Horde_Date[2.2.0].


Installation failed, reverting ./composer.json to its original content.

@ChristophWurst ChristophWurst force-pushed the horde-php7 branch 2 times, most recently from 594bdab to f4f4f90 Compare February 18, 2016 20:33
This was referenced Feb 18, 2016
Gomez added a commit that referenced this pull request Feb 24, 2016
@Gomez Gomez merged commit 5ecaae0 into master Feb 24, 2016
@Gomez Gomez deleted the horde-php7 branch February 24, 2016 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants