Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Resolve accounts loading promise in all cases #1459

Merged
merged 1 commit into from
Apr 27, 2016

Conversation

ChristophWurst
Copy link
Contributor

fixes #1458

My bad, I forgot to resolve the promise when no accounts are configured, which led to the backbone router not being started. Small bug with great impact.

@Gomez @jancborchardt @irgendwie @DeepDiver1975

@Scheirle @kajla please check if that fixes the reported issue for you

Note to myself: Test releases before releasing…

@Scheirle
Copy link
Contributor

👍 fixes the issue


But after the account setup you are somewhat stuck in a setup mode (till you reload the page manually):

  1. setup form is still visible (till you cilck on a folder)
  2. The spinning wheel (on the folder list) is always present (even after the folders are loaded)

@ChristophWurst
Copy link
Contributor Author

But after the account setup you are somewhat stuck in a setup mode (till you reload the page manually):

  1. setup form is still visible (till you cilck on a folder)
  2. The spinning wheel (on the folder list) is always present (even after the folders are loaded)

I guess that's what I described in #1424 (comment)
I'll fix that too, thanks a lot for your feedback :-)

@ChristophWurst ChristophWurst merged commit a6f9c7d into master Apr 27, 2016
@ChristophWurst ChristophWurst deleted the resolve-accounts-promise-correctly branch April 27, 2016 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants