This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
traverse folders correctly when searching by folder id #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @Gomez and @tahaalibra to be potential reviewers |
|
Thanks! Works |
|
Thanks for your help with this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The folder data structure is a tree, hence we need to traverse down all hierarchies when doing a search by id.
Note: one could optimize the algorithm by decoding the folder id and guessing the path. I'll leave that for the Mail 10.0 release 🙉
fixes https://github.com/owncloud/mail/issues/1503
@tahaalibra @Gomez @DeepDiver1975 @clementhk @Scheirle review please