Use a WHATWG URL spec compliant URL parser - see https://url.spec.wha… #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn - https://packagist.org/packages/rowbot/url requires php-gmp which is not in the ci containers and also not part of the usual owncloud installation ... |
DeepDiver1975
force-pushed
the
bugfix/url-validate
branch
2 times, most recently
from
127d219 to
6b3d484
Compare
fixed by owncloud-ci/php#108
wrong - THX @pako81 - php-gmp is a documented requirement since oc 9.0 |
…twg.org/ - this is necessary to parse the redirect url as close as browsers do.
DeepDiver1975
force-pushed
the
bugfix/url-validate
branch
from
6b3d484 to
fc7eee7
Compare
phil-davis
reviewed
Nov 5, 2019
PVince81
approved these changes
Nov 5, 2019
| @@ -9,6 +9,8 @@ config = { | |||
| 'master' | |||
| ], | |||
|
|
|||
| 'appInstallCommand': 'make vendor', | |||
|
Overriding CLA and Codecov -> merge |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
============================================
- Coverage 66.74% 66.59% -0.15%
- Complexity 229 230 +1
============================================
Files 34 34
Lines 908 910 +2
============================================
Hits 606 606
- Misses 302 304 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…twg.org/ - this is necessary to parse the redirect url as close as browsers do.