Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we clean up the URL path to avoid urlencoded /, eg #4595

Closed
butonic opened this issue Jan 8, 2021 · 10 comments · Fixed by #5894
Closed

can we clean up the URL path to avoid urlencoded /, eg #4595

butonic opened this issue Jan 8, 2021 · 10 comments · Fixed by #5894
Labels
Priority:p3-medium Normal priority

Comments

@butonic
Copy link
Member

butonic commented Jan 8, 2021

https://phoenix.owncloud.com/index.html#files/list/eos%2Fusers%2Fhugo

It would allow cnp the path and in the future make the url more similar when using other apps, eg for collabora: https://phoenix.owncloud.com/index.html#collabora/eos%2Fusers%2Fhugo?

@butonic
Copy link
Member Author

butonic commented Jan 8, 2021

might be related to spaces ... but there really is no reason to have %2F after the # in the url

@LukasHirt
Copy link
Collaborator

This requires first a update to vue-router@4 which requires vue@3. @fschade thought of a dirty hack which could do this already now but we decided against it and delay this until the update of vue and vue-router.

@LukasHirt LukasHirt added the Priority:p3-medium Normal priority label Jan 14, 2021
@labkode
Copy link
Member

labkode commented Jan 29, 2021

@LukasHirt any idea of the proposed update of the vue components?

@LukasHirt
Copy link
Collaborator

LukasHirt commented Feb 1, 2021

any idea of the proposed update of the vue components?

No progress so far. The update is not part of the current sprint. We were focusing on our accessibility tasks at the moment because of the WCAG certification. @labkode Is this ticket urgent for you? Last time I heard it wasn't, so we weren't putting too much priority to it.

@labkode
Copy link
Member

labkode commented Feb 2, 2021

Hi @LukasHirt, it is as we plan to expose the new system, where user would be able to copy/paste the url to access the resources and if the URL changes this will break behaviour.

@LukasHirt
Copy link
Collaborator

The current sprint ends in two weeks - should we escalate this and tackle this already @pmaier1 or would it be possible to wait until the next one @labkode ?

@labkode
Copy link
Member

labkode commented Feb 2, 2021

@LukasHirt it can wait until next one, thanks for following it up

@kulmann
Copy link
Contributor

kulmann commented Jun 19, 2021

We were thinking about an entirely new URL format recently. There was some concepting done here #5313 but it stalled lately. Needs to be on our agenda again. cc @tbsbdr

@pascalwengerter
Copy link
Contributor

At least the %2F encoding should be fixed via #5715 (patched until we switch to Vue3) and just landed in master, closing this issue for now (yet we'll perhaps need some more routing-related ones in the future)

@labkode
Copy link
Member

labkode commented Oct 8, 2021

Files app use non-url encoded paths, just missing some media urls @kulmann knows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants