Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable image tags in textile_restricted #274

Open
envycontent opened this issue Feb 24, 2015 · 8 comments
Open

Enable image tags in textile_restricted #274

envycontent opened this issue Feb 24, 2015 · 8 comments

Comments

@envycontent
Copy link
Contributor

Adding a representative image to a talk and a series is a feature of old talks which hasn't made it over to the new talks. This was because the story was relatively low priority for the overall effort required to implement it. There is one department however who make good use of images for their talks. I was wondering if a workaround would be to enable image tags in textile_restricted for the series and talk abstracts (noimage=False). This would mean that an editor could embed an image from an external source.

As most people will not know how to add an image in textile, most will look at the documentation which will give them instructions on including alternative text and choosing an appropriate size for the image.

@ahaith
Copy link
Contributor

ahaith commented Feb 27, 2015

The textile plugin breaks external image references when the auto-link option is enabled.
It might be possible to fix the regexp used to pick up links so that urls within img tags aren't picked up, if we fork the plugin.

@envycontent
Copy link
Contributor Author

Let's wait until this has been discussed in the Board Meeting on Thursday.

@envycontent
Copy link
Contributor Author

If this is textile 2.2.2? Could we file a bug with them? https://pypi.python.org/pypi/textile

@ahaith
Copy link
Contributor

ahaith commented Mar 5, 2015

I've filed an issue
textile/python-textile#17

@envycontent
Copy link
Contributor Author

We should probably close this issue for the moment. The Board decided that images should be included in the database.

@envycontent
Copy link
Contributor Author

I'm reopening this issue, due to recent discussions about ongoing development and complaints about lack of images. I think we may be back to this solution for images, at least for the short term. I've noticed that the bug we filed here has been fixed and may well be merged:

textile/python-textile#17

Would it be feasible to apply a quick fix if that's the case. I can work at my end on making it possible for users to upload images to our image management system.

@envycontent
Copy link
Contributor Author

We've established that the fix in python-textile merely removes the auto-link option, so we can't have images AND auto-link

@envycontent
Copy link
Contributor Author

Hello
I've been asked again about images and took a look at the python-textile code (I was looking to see if any updates had been made).

auto-link has still been removed and I was just wondering if it would be feasible to deploy the latest python-textile and just let users know that they should format links themselves - it isn't too difficult. As for previous talks - I'm sort of assuming that unlinked text URLs would be fairly self-explanatory and not too much of a big deal (as the events have passed).

Now might be a good time to do it, before everyone starts adding talks for Michaelmas term.

Could you let me know if that's a feasible tweak or if I'm talking rubbish :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants