From f3b85ddaa3b3f0ec90bfa1c75659f553d846ac49 Mon Sep 17 00:00:00 2001 From: overlookmotel Date: Fri, 20 Sep 2024 10:00:34 +0100 Subject: [PATCH] refactor(ast_tools): shorten code --- tasks/ast_tools/src/generators/visit.rs | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/tasks/ast_tools/src/generators/visit.rs b/tasks/ast_tools/src/generators/visit.rs index a621ce4ea884c..20a984d475386 100644 --- a/tasks/ast_tools/src/generators/visit.rs +++ b/tasks/ast_tools/src/generators/visit.rs @@ -175,14 +175,6 @@ impl<'a> VisitBuilder<'a> { } } - fn get_iter(&self) -> TokenStream { - if self.is_mut { - quote!(iter_mut) - } else { - quote!(iter) - } - } - fn get_visitor( &mut self, def: &TypeDef, @@ -262,8 +254,7 @@ impl<'a> VisitBuilder<'a> { let (walk_body, may_inline) = if collection { let singular_visit = self.get_visitor(def, false, None); - let iter = self.get_iter(); - let iter = if self.is_mut { quote!(it.#iter()) } else { quote!(it) }; + let iter = if self.is_mut { quote!(it.iter_mut()) } else { quote!(it) }; ( quote! { for el in #iter { @@ -511,7 +502,7 @@ impl<'a> VisitBuilder<'a> { } }, TypeWrapper::VecOpt => { - let iter = self.get_iter(); + let iter = if self.is_mut { quote!(iter_mut) } else { quote!(iter) }; quote! { for #name in it.#name.#iter().flatten() { visitor.#visit(#name #(#args)*);