Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser)!: use BindingIdentifier for namespace declaration names #6003

Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat(parser)!: use BindingIdentifier for namespace declaration names #6003

merged 1 commit into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. feat(parser)!: use BindingIdentifier for namespace declaration na… 

    …mes (#6003)

Use `BindingIdentifier` instead of `IdentifierName` so that AST visitors can access the bound symbol id for the namespace's name. This makes namespace consistent with other named declarations, such as `Class`, `Function`, and `TSInterfaceDeclaration`.

We should consider modifying `TSModuleDeclarationName::StringLiteral(...)` to also store a `symbol_id`, since one gets bound in semantic for it as well.
    @DonIsaac
    DonIsaac committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    01b878e View commit details
    Browse the repository at this point in the history