From bd81c5134c03072441df872a6eb8944d1d72b600 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Sun, 6 Oct 2024 00:51:27 +0000
Subject: [PATCH] fix(transformer): exponentiation transform: fix duplicate
 symbols (#6300)

Identifier was being cloned unnecessarily, creating an extra symbol.
---
 .../src/es2016/exponentiation_operator.rs     | 30 ++++++++-----------
 .../snapshots/babel.snap.md                   |  6 ----
 2 files changed, 13 insertions(+), 23 deletions(-)

diff --git a/crates/oxc_transformer/src/es2016/exponentiation_operator.rs b/crates/oxc_transformer/src/es2016/exponentiation_operator.rs
index fc3f3d6fa9495..37abfc342203c 100644
--- a/crates/oxc_transformer/src/es2016/exponentiation_operator.rs
+++ b/crates/oxc_transformer/src/es2016/exponentiation_operator.rs
@@ -146,17 +146,14 @@ impl<'a, 'ctx> ExponentiationOperator<'a, 'ctx> {
         nodes: &mut Vec<'a, Expression<'a>>,
         ctx: &mut TraverseCtx<'a>,
     ) -> Option<Exploded<'a>> {
-        let node = node.as_simple_assignment_target_mut()?;
-        let obj = self.get_obj_ref(node, nodes, ctx)?;
         let (reference, uid) = match node {
-            SimpleAssignmentTarget::AssignmentTargetIdentifier(ident) => {
-                let reference =
-                    AssignmentTarget::AssignmentTargetIdentifier(ctx.ast.alloc(
-                        ctx.clone_identifier_reference(ident.as_ref(), ReferenceFlags::Write),
-                    ));
-                (reference, obj)
+            AssignmentTarget::AssignmentTargetIdentifier(_) => {
+                let obj = self.get_obj_ref(node, nodes, ctx).unwrap();
+                let ident = ctx.ast.move_assignment_target(node);
+                (ident, obj)
             }
-            match_member_expression!(SimpleAssignmentTarget) => {
+            match_member_expression!(AssignmentTarget) => {
+                let obj = self.get_obj_ref(node, nodes, ctx).unwrap();
                 let member_expr = node.to_member_expression_mut();
                 let computed = member_expr.is_computed();
                 let prop = self.get_prop_ref(member_expr, nodes, ctx)?;
@@ -202,12 +199,12 @@ impl<'a, 'ctx> ExponentiationOperator<'a, 'ctx> {
     /// Make sure side-effects of evaluating `obj` of `obj.ref` and `obj[ref]` only happen once.
     fn get_obj_ref(
         &mut self,
-        node: &mut SimpleAssignmentTarget<'a>,
+        node: &mut AssignmentTarget<'a>,
         nodes: &mut Vec<'a, Expression<'a>>,
         ctx: &mut TraverseCtx<'a>,
     ) -> Option<Expression<'a>> {
         let reference = match node {
-            SimpleAssignmentTarget::AssignmentTargetIdentifier(ident) => {
+            AssignmentTarget::AssignmentTargetIdentifier(ident) => {
                 let reference = ctx.symbols().get_reference(ident.reference_id().unwrap());
                 if let Some(symbol_id) = reference.symbol_id() {
                     // this variable is declared in scope so we can be 100% sure
@@ -229,12 +226,11 @@ impl<'a, 'ctx> ExponentiationOperator<'a, 'ctx> {
                     ReferenceFlags::Read,
                 ))
             }
-            match_member_expression!(SimpleAssignmentTarget) => {
-                let expr = match node {
-                    SimpleAssignmentTarget::ComputedMemberExpression(e) => &mut e.object,
-                    SimpleAssignmentTarget::StaticMemberExpression(e) => &mut e.object,
-                    SimpleAssignmentTarget::PrivateFieldExpression(e) => &mut e.object,
-                    _ => unreachable!(),
+            match_member_expression!(AssignmentTarget) => {
+                let expr = match node.to_member_expression_mut() {
+                    MemberExpression::ComputedMemberExpression(e) => &mut e.object,
+                    MemberExpression::StaticMemberExpression(e) => &mut e.object,
+                    MemberExpression::PrivateFieldExpression(e) => &mut e.object,
                 };
                 let expr = ctx.ast.move_expression(expr);
                 // the object reference that we need to save is locally declared
diff --git a/tasks/transform_conformance/snapshots/babel.snap.md b/tasks/transform_conformance/snapshots/babel.snap.md
index a12fd2a2214ce..823a2e50b9a28 100644
--- a/tasks/transform_conformance/snapshots/babel.snap.md
+++ b/tasks/transform_conformance/snapshots/babel.snap.md
@@ -1630,12 +1630,6 @@ x Output mismatch
 
 # babel-plugin-transform-exponentiation-operator (1/4)
 * exponentiation-operator/assignment/input.js
-Symbol reference IDs mismatch for "num":
-after transform: SymbolId(0): [ReferenceId(0), ReferenceId(1), ReferenceId(2)]
-rebuilt        : SymbolId(0): [ReferenceId(0), ReferenceId(2)]
-Reference flags mismatch for "num":
-after transform: ReferenceId(2): ReferenceFlags(Write)
-rebuilt        : ReferenceId(0): ReferenceFlags(Read | Write)
 Reference flags mismatch for "num":
 after transform: ReferenceId(1): ReferenceFlags(Write)
 rebuilt        : ReferenceId(2): ReferenceFlags(Read)