Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): should regard comments where after = as leading comments of next token #6355

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix(parser): should regard comments where after = as leading comments of next token #6355

merged 1 commit into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. fix(parser): should regard comments where after = as leading commen… 

    …ts of next token (#6355)

A part of fixing https://github.com/rolldown/rolldown/pull/2375/files#r1789011257

### Compare to `Babel`
This is also among its behavior, see

<img width="1470" alt="image" src="https://github.com/user-attachments/assets/1b1f9c78-3e44-495d-b2f7-38e6c3bc8bf1">

### Compare to `esbuild`

I haven't looked through related code from esbuild, from its playground, the behavior looks the same

https://esbuild.github.io/try/#dAAwLjI0LjAAAGNvbnN0IEEgPSAvLyBzZGRkZGQKKCkgPT4ge30
    @Dunqing
    Dunqing committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1380d8b View commit details
    Browse the repository at this point in the history