From 4ce14f7d36a9f045bb09579e65aa80e505d155cd Mon Sep 17 00:00:00 2001 From: Matthew Buckett Date: Thu, 23 Nov 2023 11:37:15 +0000 Subject: [PATCH] Reduce the logging level of the "normal" errors. It's expected that request will be made that are missing parameters and are made for invalid registration IDs. So they are errors, but they aren't a proper internal error that needs investigating like other exceptions. --- .../lti/web/OAuth2AuthorizationRequestRedirectFilter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/uk/ac/ox/ctl/lti13/security/oauth2/client/lti/web/OAuth2AuthorizationRequestRedirectFilter.java b/src/main/java/uk/ac/ox/ctl/lti13/security/oauth2/client/lti/web/OAuth2AuthorizationRequestRedirectFilter.java index aab52a8..a5c4b8f 100644 --- a/src/main/java/uk/ac/ox/ctl/lti13/security/oauth2/client/lti/web/OAuth2AuthorizationRequestRedirectFilter.java +++ b/src/main/java/uk/ac/ox/ctl/lti13/security/oauth2/client/lti/web/OAuth2AuthorizationRequestRedirectFilter.java @@ -205,14 +205,14 @@ private boolean hasNoPlatform(HttpServletRequest request) { private void unsuccessfulRedirectForAuthorization(HttpServletRequest request, HttpServletResponse response, Exception failed) throws IOException, ServletException { - if (logger.isErrorEnabled()) { - logger.error("Authorization Request failed: " + failed.toString(), failed); - } if (failed instanceof InvalidInitiationRequestException) { + logger.info("Invalid initiation request: "+ failed); response.sendError(HttpStatus.BAD_REQUEST.value(), failed.getMessage()); } else if (failed instanceof InvalidClientRegistrationIdException) { + logger.info("Invalid registration ID: "+ failed); response.sendError(HttpStatus.NOT_FOUND.value(), failed.getMessage()); } else { + logger.error("Authorization Request failed: " + failed.toString(), failed); response.sendError(HttpStatus.INTERNAL_SERVER_ERROR.value(), HttpStatus.INTERNAL_SERVER_ERROR.getReasonPhrase()); } }