Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipped tests due to no GetTotalMemory implementation #6

Open
iliana opened this issue Oct 21, 2024 · 0 comments
Open

skipped tests due to no GetTotalMemory implementation #6

iliana opened this issue Oct 21, 2024 · 0 comments
Labels
cleanup Nice-to-have cleanup work but not urgent

Comments

@iliana
Copy link
Collaborator

iliana commented Oct 21, 2024

func GetTotalMemoryWithoutLogging() (int64, string, error) {
totalMem, err := func() (int64, error) {
mem := gosigar.Mem{}
if err := mem.Get(); err != nil {
return 0, err
}

We don't implement this function in our patched gosigar which doesn't affect runtime (as we're using Cockroach, anyway), but we have to skip a couple of tests (skips added in f46ecb2).

Presumably the metrics recorder is what continually logs "not implemented on illumos" every 10s or so during runtime.

@iliana iliana added the cleanup Nice-to-have cleanup work but not urgent label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Nice-to-have cleanup work but not urgent
Projects
None yet
Development

No branches or pull requests

1 participant