Skip to content
This repository has been archived by the owner on Nov 11, 2018. It is now read-only.

Support for Z shell #26

Open
shellkr opened this issue May 13, 2013 · 28 comments
Open

Support for Z shell #26

shellkr opened this issue May 13, 2013 · 28 comments

Comments

@shellkr
Copy link

shellkr commented May 13, 2013

Right now Finalterm only supports Bash which is good as it is the most popular shell.. but Zsh is also popular and should be possible to use. Zsh offer a lot of improvements over Bash.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@p-e-w
Copy link
Owner

p-e-w commented May 13, 2013

I agree, though that will probably only happen after Final Term (with bash) is fully stable. But I definitely intend to support all major shells in the future.

@nerzhul
Copy link

nerzhul commented May 21, 2013

I approve @Almehdi i use zsh every time and unfortunately i cannot use this very good terminal emulator with ZSH because the cursor is at the begin of the line, not after the prompt :s

@super-nathan
Copy link

frankly was trying to build this until I saw no ZSH,

:(

@p-e-w
Copy link
Owner

p-e-w commented May 22, 2013

Please be patient, folks :)

I'll revisit zsh once Final Term works properly with bash.

@nerzhul
Copy link

nerzhul commented May 22, 2013

This problem is also present when we do a SSH session on a server with zsh :(

@ghost
Copy link

ghost commented Jul 8, 2013

@p-e-w Does "all major shells" include fish?

@p-e-w
Copy link
Owner

p-e-w commented Jul 8, 2013

@AlyxR: It does, to me at least :)

See #44

@nerzhul
Copy link

nerzhul commented Jul 8, 2013

Maybe you must change your terminal approach because of variety of shells ?

@tsdh
Copy link

tsdh commented Jul 10, 2013

What is finalterm concerned about what shell it's running? The output of commands is the same in every shell, or does it interact more with the shell than parsing the output of known commands?

IMHO, if it was possible, I'd welcome if it just runs whatever SHELL the user has set. Feel free to state explicitly that it might break with everything except bash, but I'd still be able to run my beloved, highly configured ZSH.

@tsdh
Copy link

tsdh commented Jul 10, 2013

Ah, ok, I've just seen that no feature making finalterm innovative works when I start a zsh manually. Do you have some pointers/docs on what's needed to make it work with other shells?

@p-e-w
Copy link
Owner

p-e-w commented Jul 11, 2013

@tsdh: What's needed to make another shell work with Final Term is a startup script along the lines of https://github.com/p-e-w/finalterm/blob/master/data/Startup/bash_startup that injects the custom control sequences that tell Final Term what is going on inside the shell.

@masnormen
Copy link

Still waiting 'till the Final Term is fully stable! I can't wait for the Final Term with Zsh support! :D

@brodock
Copy link

brodock commented Oct 3, 2013

+1

@Cosmicist
Copy link

+1! I just tried finalterm and zsh + finalterm would make for a hell of a nerdgasm :P

@StuntsPT
Copy link

Just to add my +1 to have zsh support in finalterm. =-)

@Malsasa
Copy link

Malsasa commented Nov 25, 2013

+1 zsh support after Finalterm with bash was stable.

@aboutaaron
Copy link

👍 I also would love finalterm with ZSH support.

@NelsonBrandao
Copy link

👍

@p-e-w
Copy link
Owner

p-e-w commented Jan 19, 2014

With the most recent changes, zsh support has become a much closer goal than it was before. Please see http://blog.finalterm.org/2014/01/the-marriage-of-terminal-and-shell.html for some details.

@gamesbrainiac
Copy link

+1 This would be a highly appreciated feature

@LightGuard
Copy link

👍

@qwc
Copy link

qwc commented Jul 9, 2014

👍 bump
FinalTerm looks nice, feels nice, but is not usable with zsh for time being. At least with my configuration (includes oh-my-zsh).

@mjacobus
Copy link

mjacobus commented Sep 8, 2014

If you open a normal teminal, attach it to temux and then open finalterm, and attach to that same session you will have zshell inside finalterm.

@nerzhul
Copy link

nerzhul commented Sep 10, 2014

@mjacobus very hard whereas there is an option to change finalterm default shell into dconf (which doesn't work)

@detiber
Copy link
Contributor

detiber commented Sep 11, 2014

I've started to take a crack at adding zsh support here: https://github.com/detiber/finalterm/tree/zsh

So far I'm able to load finalterm using zsh as the shell, but the context menus aren't currently working properly (nor is wget progress). Any comments/suggestions are greatly appreciated.

Bootstrapping steps are here: https://github.com/detiber/finalterm/blob/zsh/README-ZSH.md

I've also started a copr build (for fedora/centos/rhel users) here: https://copr.fedoraproject.org/coprs/jdetiber/finalterm-zsh/

@lwandrebeck
Copy link

Termlets are bash-centric (start with #!/bin/bash), that may explain why it doesn’t work.
We’d need to split them shell by shell to use their own internals for speed, imho.
See #338 :)

@detiber
Copy link
Contributor

detiber commented Sep 11, 2014

@lwandrebeck indeed, I didn't get a chance to dig into the Termlets too much (other than calling out to them using zsh, and updating them to autoload functions if $ZSH_VERSION is set).

When I get some more time to hack on it I'll work on implimenting them in a zsh compatible way. I was mostly happy to have abstracted out the bashisms that were preventing zsh from even loading as the default shell.

I submitted a #355 to help solicit better feedback on the changes I've made so far.

@nashley nashley mentioned this issue Sep 25, 2014
@tuxayo
Copy link

tuxayo commented Oct 30, 2014

👍 That would be a killer combo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests