Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyURL - use API #7

Open
genio opened this issue Mar 17, 2016 · 1 comment
Open

TinyURL - use API #7

genio opened this issue Mar 17, 2016 · 1 comment
Labels

Comments

@genio
Copy link
Member

genio commented Mar 17, 2016

Use their API: http://www.tiny-url.info/open_api.html

Making use of the API rather than the old /api-create.php endpoint would likely get rid of the random failures in the test suite as they don't limit the usage based on time at that endpoint.

However, signing up for an account makes testing more difficult. We could mock the service for testing purposes and have end-users have to get their API keys on their own.

@genio genio added the Bug label Mar 17, 2016
@oliwer
Copy link

oliwer commented Mar 24, 2016

Other option : use the new API if the user has given a key, and fallback to the old API by default. You would still need to mock the service for tests i guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants