-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to use with map
#15
Comments
<Truncate>
{Array(300).fill('word ').map((content, i) => (
<span key={i}>{content}</span>
))}
</Truncate> works fine for me. Could you provide some additional info:
For that matter, could you do console.log(
map((x, i) => (
<Attachment
featuresFormatted={get(event, "featuresFormatted")}
index={i}
key={get(x, "uri")}
attachment={x}
highlightedAttachmentNames={highlightedAttachmentNames}
/>
), get(event, "attachments"))
); and paste the output here? |
@pablosichert well i'm silly. this is my own problem. i looked at the source code and took notice that it is genuinely just for text nodes. i'm making an attempt to map over a component that returns html. thanks for the thorough response. to follow-up, what do you think the likelihood is of having the ability to truncate components wholely vs text nodes. is it worth a PR? in my case, i've got n number of |
No worries :-) There has been a similar feature request #8. I had some ideas on how to implement a solution that works for any node, but don't have an overall plan yet. Also, can't promise any schedule for this feature until we need it in production. Closing this for now. As a solution for your use case, wouldn't something like this work? let attachments = [];
let _attachments = get(event, "attachments");
let numAttachments = showAll ? _attachments.length : Math.min(_attachments.length, 3);
for (let i = 0; i < numAttachments; i++) {
let attachment = attachments[i];
attachments.push(
<Attachment
featuresFormatted={get(event, "featuresFormatted")}
index={i}
key={get(attachment, "uri")}
attachment={attachment}
highlightedAttachmentNames={highlightedAttachmentNames}
/>
);
}
return (
<div>{attachments}</div>
); And some button in your UI that toggles the |
fails for me :(
The text was updated successfully, but these errors were encountered: