-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default https #9
Conversation
Hi @xurble, thanks for your contribution! it makes sense at this time where everything is being HTTPS by default. I'll take a look tomorrow to review this changes and prepare a new release because changing the default value of |
You should take the plunge and release a 1.0 😀 In all seriousness, though it's been a really useful library for me. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks very good and tested! Just one question regarding the changes on README.md
By the way, when reviewing this PR I spotted an old issue, doctest strings aren't being tested, so I opened and merged this PR to fix it. @xurble if you could rebase this branch from master and also update the protocol ( |
It would be probably the case 😅 |
OK, I am terrible with pull requests. I think that this is now up to date with your doc string test change and I've fixed the docstrings and the readme to be correct. |
Everything looks good and ready 👍 I'll publish a new release asap. @xurble thank you very much for your time and this great enhancement! |
The new release 1.0.0 is now available on PyPI https://pypi.org/project/libgravatar/ 🚀 |
Gravatar has changed so that it now recommends the https:// urls as the default
The PR reverses the default of use_ssl to be False
It also makes the domain always be www.gravatar.com since that seems to be the modern recommendation, they don't mention secure.gravatar.com any more.
https://en.gravatar.com/site/implement/images/
Finally at adds a use_ssl (default False) parameter to the get_profile method.