Add support for using AsyncFileReader on filesystems without O_DIRECT…

… support. This fixes a test failure on the Linux tmpfs filesystem. Fixes: microsoft#329
pabs3 · Apr 1, 2023 · f3a5dcf · f3a5dcf
1 parent a965529
commit f3a5dcf
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/AnnService/inc/Helper/AsyncFileReader.h b/AnnService/inc/Helper/AsyncFileReader.h
@@ -521,6 +521,10 @@ namespace SPTAG
                 std::uint16_t threadPoolSize = 4)
             {
                 m_fileHandle = open(filePath, O_RDONLY | O_DIRECT);
+                // O_DIRECT isn't supported on some filesystems
+                if (m_fileHandle <= 0 && errno == EINVAL) {
+                    m_fileHandle = open(filePath, O_RDONLY);
+                }
                 if (m_fileHandle <= 0) {
                     SPTAGLIB_LOG(LogLevel::LL_Error, "Failed to create file handle: %s\n", filePath);
                     return false;