Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve failover mechanism #386

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Improve failover mechanism #386

wants to merge 26 commits into from

Conversation

srieckhof
Copy link
Contributor

No description provided.

stefan.rieckhof added 26 commits November 14, 2024 11:34
set log level of some messages to info to have more visibility of the…
ead7df2 
… errors; improve log messages and code comments (NO LOGIC CHANGES)
try refreshing lock TTL well before TTL expiration
c3c2435
adjust the retry strategy for more sanity when trying to obtain the l…
72f31af 
…ock by a passive/undefined pod
try immediate lock reacquisition if lock refresh failed
995a3fe
add retry backoff to locker.Obtain() to avoid a retry loop; rename va…
da7b3a3 
…riable
add nil check before trying to refresh a lock
a8c6a30
rename ticker t to refresh
80ff4b2
improvements for readability
8ecf3e0
improve backoff interval and comment
06c105a
improve/add comments; implement safeguard when lock.TTL() returns an …
10aecd4 
…error
decrease log level for most logs to debug; enforce minimum refresh ti…
3b13d0a 
…me after lock acquisition
DEBUG: add Stefan to log messages for testing
a1eba4a
replace *redislock.Client by an interface, that is, LockClient to all…
4ba1382 
…ow for dependency injection also with a mock redis lock client
create mocks for redislock.Client and redislock.Lock
a35d417
remove m.Called() from Obtain()
75e6f63
add some more log lines
419751c
add some more log lines
a033516
add some more log lines
d9b2a29
add some more log lines
7eef210
call lock.TTL() with a timeout context
fc86408
pass redis client instead of redislock client to NewActivePassive()
e2f8b1a
delete lock and redislock mocks
ac90f64
check for lock==nil before calling lock.TTL()
7f0039e
do lock operations only if Redis is reachable
528e9e4
add check for lock key existence to prevent interface {} conversion e…
333e931 
…rror when trying to get the TTL from the lock
recover from panic in lock.TTL() and become undefined in this case
20cf4bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srieckhof