Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu search does not yield any results #361

Open
rayment opened this issue Jan 9, 2023 · 5 comments
Open

Context menu search does not yield any results #361

rayment opened this issue Jan 9, 2023 · 5 comments

Comments

@rayment
Copy link
Contributor

rayment commented Jan 9, 2023

When the context menu is used to filter nodes, no results are shown despite partial or complete matches.

Demonstration

Steps to reproduce:

  1. Create an application with at least one node type.
  2. Right click the graph view.
  3. Type in anything into the filter bar.
  4. Observe that no results appear except for empty categories.

This bug occurs on both Windows and Linux for version 3.0.7.

Environment:

OS Qt Compiler
Gentoo Linux, kernel 6.1.0 5.15.7 gcc 11.3.1
Windows Server 2022 10.0.20348 Build 20348 5.15.2 MSVC 19.34.31937.0

I've opened PR #360 in order to fix this as well as stop displaying empty categories as they clutter the screen.

@zmoth
Copy link
Contributor

zmoth commented Jan 9, 2023

Hello,It has been fixed in #348.

And new features of sorting have been added.

@rayment
Copy link
Contributor Author

rayment commented Jan 9, 2023

Hello,It has been fixed in #348.

And new features of sorting have been added.

Ah, I did read your fix but missed the part about fixing the non-returned results. Does your filter sort also take care of the empty categories? If so, I'll close this as a duplicate.

@paceholder
Copy link
Owner

Guys, thanks for your contributions.

I don't want to waste the work of anyone. But I like this small fix more because it is less invasive and is easier to follow.
Maybe we could merge this one first and then go over the heavy stuff written by @QianMoth
Sorry that I did not manage to look over all the details quickly.

I can rebase @QianMoth 's work later manually and merge different topics one-by-one.

@zmoth
Copy link
Contributor

zmoth commented Jan 9, 2023

hi @rayment There are no new features that you have added, I will try to add them.

@rayment
Copy link
Contributor Author

rayment commented Jan 9, 2023

hi @rayment There are no new features that you have added, I will try to add them.

No worries. I've only added the bare minimum to render the search functional. I'm happy to test on Linux/Windows if need be. Hopefully I'll have a macOS environment in a while too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants