Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description paramater to manager.create_device #121

Open
pnhowe opened this issue Aug 20, 2021 · 2 comments
Open

add description paramater to manager.create_device #121

pnhowe opened this issue Aug 20, 2021 · 2 comments
Milestone

Comments

@pnhowe
Copy link
Contributor

pnhowe commented Aug 20, 2021

please add the "description" parameter to the create_device method of the Manager. Also I noticed a few other missing parameters: ssh_keys, no_ssh_keys, private_ipv4_subnet_size, ip_addresses. Might be nice to have all the API's create device parameters exposed.

@displague displague added this to the 1.46 milestone Aug 21, 2021
@displague
Copy link
Member

Indeed @pnhowe. This client is behind API parity in a number of ways. I'm flagging these attributes to be added in a near release, but I don't have any specific timelines.

The Equinix Metal API Swagger2/OAS2 Spec is public and can be used to generate a client, as in https://github.com/displague/metal-python/blob/main/metal/types/device_create_input.py

I'm working towards making generated clients such as this the primary go-to client and eventually deprecating handwritten clients such as this.

Let us know if you are blocked by this or if you would like to have any contributions reviewed and released to add this functionality.

#91 is an open PR to add ip_address and we could further that along if it helps.

@displague
Copy link
Member

created_by is an attribute that is missing from the Device class which some users have expressed a desire to have access to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants