Move CI for packet-python to cloud.drone.io #81
Comments
|
oops I did not notice that it wasn't set to public. I've rectified that. We can still decide to move over to cloud.drone.io, but it would be for different reasons. |
|
@vielmetti are there other benefits to using Drone on this particular project? My latest comment in #58 reflects an interest in using Github Workflows for this project. I'm sure we can get a release process tied into Drone if it is preferable. |
|
Drone Cloud is a pretty well-known quantity here and it runs on Packet infra, so we'd have some folks who already knew what was what there. There is a known architectural issue with Github runners on public repos, see https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security-with-public-repositories for that discussion. |
|
By avoiding E2E testing and using mocks (#93 would be nice to have), we can avoid the need for secrets in testing PRs. Release PRs can be made with branches on this 'origin' repository (only possible by maintainers who already have access to the relevant secrets). This approach is in place for packngo and seems to work well enough. The Terraform provider takes a similar approach, but E2E tests are run only run on the 'origin' branches. We don't have anything in place to authorize user branches to be tested in this way. I'd like to close this issue out in favor of what is already in place with:
Semi-related, I have been noticing that drone is still executing against PRs in this project, even though .drone.yml has been removed. |
In the interests of supporting a public dashboard for CI status for this integration, consider moving this repo to use cloud.drone.io for CI.
Originally posted by @mmlb in #80 (comment)
The text was updated successfully, but these errors were encountered: