Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Upgrade go-logr across the 1.0 breaking change #50

Open
nshalman opened this issue Jan 14, 2022 · 0 comments · May be fixed by #51
Open

Feature Request: Upgrade go-logr across the 1.0 breaking change #50

nshalman opened this issue Jan 14, 2022 · 0 comments · May be fixed by #51
Labels
enhancement New feature or request

Comments

@nshalman
Copy link
Member

github.com/packethost/pkg/log is built on github.com/go-logr/logr v0.2.1

It would be nice to upgrade to the latest, but that will entail crossing the v1.0 breaking change as mentioned in https://github.com/go-logr/logr/releases/tag/v1.0.0-rc1 and implemented in go-logr/logr#42
@nshalman nshalman added the enhancement New feature or request label Jan 14, 2022
@joelrebel joelrebel linked a pull request Jan 25, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log/logr/v2 with logr, zapr deps updated to v1.2.2 joelrebel/pkg
1 participant
@nshalman