Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing examples #370

Closed
4 tasks done
JP-Ellis opened this issue Sep 8, 2023 · 1 comment · Fixed by #387
Closed
4 tasks done

Fix existing examples #370

JP-Ellis opened this issue Sep 8, 2023 · 1 comment · Fixed by #387
Assignees
Labels
smartbear-supported This issue is supported by SmartBear type:bug Something isn't working type:feature New feature

Comments

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Sep 8, 2023

The existing examples seem a bit fragile and required me to make some changes to the underlying code to get them to work. The barrier to getting them to work should be decreased to help facilitate adoption.

Some of the changes to look at:

  • Fix issues with the shared fixture not being able to publish the (seemingly inexistent) Pact file

  • Reuse the pact broker between the examples, instead of spinning it up and down every time

  • Review whether we need to support SSL for this example

  • See whether it should be integrated with the broader pytest suite (perhaps gated behind a flag?)

    Opted to just have them in a separate directory. `pytest examples/` (or `hatch run examples`) will suffice
    
@JP-Ellis JP-Ellis added type:bug Something isn't working smartbear-supported This issue is supported by SmartBear type:feature New feature labels Sep 8, 2023
@JP-Ellis JP-Ellis self-assigned this Sep 8, 2023
@mefellows mefellows added smartbear-supported This issue is supported by SmartBear and removed smartbear-supported This issue is supported by SmartBear labels Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-1306). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartbear-supported This issue is supported by SmartBear type:bug Something isn't working type:feature New feature
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants