Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook improvements #38

Closed
spoukke opened this issue Feb 9, 2023 · 0 comments · Fixed by #129
Closed

Webhook improvements #38

spoukke opened this issue Feb 9, 2023 · 0 comments · Fixed by #129
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.2.0

Comments

@spoukke
Copy link
Contributor

spoukke commented Feb 9, 2023 •
edited by Alan-pad
Loading

Repository URL comparison

For GitHub events we compare the repository url to webUrl and the sshUrl received in the webhook.
We should be able to parse thos url, reducing the number of compraisons.
For GitLab, we do not comprae to any sshUrl at the moment

Multiple files triggering layer plan

Today our webhook only checks for change in the path of the layer
For Terraform codebases that have local modules we need to be able to specify those modules' paths
For Terragrunt it's especially important as there is multiple levels of inputs
@spoukke spoukke added this to the v0.2.0 milestone Feb 21, 2023
@spoukke spoukke added enhancement New feature or request good first issue Good for newcomers labels Feb 21, 2023
@Alan-pad Alan-pad changed the title Repository URL comparison improvements Webhook improvements Mar 14, 2023
@JulienJourdain JulienJourdain linked a pull request May 25, 2023 that will close this issue
feat(webhook): add additional paths trigger #129
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

feat(webhook): add additional paths trigger padok-team/burrito
1 participant
@spoukke