Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: P4PADEV-244 create structure new microservice arc #1

Merged

Conversation

Giuseppe-LaManna
Copy link
Collaborator

@Giuseppe-LaManna Giuseppe-LaManna commented May 2, 2024

List of Changes

  • Add base structure
  • Add Helm
  • Add Dockerfile
  • Add Config build.gradle
  • Add SwaggerConfig
  • Add endpoint swagger and actuator
  • Add code-review
  • Add deploy

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Dockerfile Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
.devops/deploy-pipelines.yml Outdated Show resolved Hide resolved
helm/values-dev.yaml Outdated Show resolved Hide resolved
helm/values-prod.yaml Outdated Show resolved Hide resolved
helm/values-uat.yaml Outdated Show resolved Hide resolved
helm/values.yaml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
build.gradle.kts Outdated
}
}

gitProperties {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the list of keys inserted allows you to control the properties of git.properties by selecting only those of interest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need these properties somewhere in the project?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A git.properties file, with this properties will be generated when building project and we can see git details via info endpoint of spring-boot-actuator

@Giuseppe-LaManna Giuseppe-LaManna marked this pull request as ready for review May 7, 2024 08:26
@Giuseppe-LaManna Giuseppe-LaManna requested a review from a team as a code owner May 7, 2024 08:26
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Giuseppe-LaManna Giuseppe-LaManna merged commit 9bc7a2f into develop May 8, 2024
3 checks passed
@Giuseppe-LaManna Giuseppe-LaManna deleted the P4ADEV-244-create-structure-new-microservice-arc branch May 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants