feat: P4PU-329 save access token #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and-mora
suggested changes
Jul 31, 2024
src/test/java/it/gov/pagopa/arc/service/CustomAuthenticationSuccessHandlerTest.java
Show resolved
Hide resolved
and-mora
reviewed
Aug 1, 2024
|
|
||
| @Override | ||
| public IamUserInfoDTO getUserInfo(String accessToken) { | ||
| return tokens.getOrDefault(accessToken, null); |
There was a problem hiding this comment.
consider the use of Optional as return param
and-mora
approved these changes
Aug 1, 2024
and-mora
reviewed
Aug 1, 2024
| } | ||
| @Test | ||
| void givenAuthenticationRequestThenInResponseGetCustomTokenResponse() throws IOException { | ||
| String sample_id_token = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ik1hcmNvIiwiaWF0IjoxNTE2MjM5MDIyLCJmaXNjYWxOdW1iZXIiOiI3ODkwMTIiLCJmYW1pbHlOYW1lIjoiUG9sbyIsImVtYWlsIjoibWFyY28ucG9sb0BleGFtcGxlLmNvbSIsImlzcyI6Imlzc3VlciJ9.AErwXpbHrT_0WvN86QuQ0nvnZndVxt8jnmiD1lfj1_A"; |
There was a problem hiding this comment.
Sonar points out the naming of sample_id_token as issue. Try with camelCase
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Added feature that saves each access token with relative user data in in-memory storage
Motivation and Context
For the future purpose we should have a store where all active access_token shoud be stored
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: