Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-833] Sorting algorithms for PSP bundles #6382

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request updating the sorting algorithm for PSP bundles

  • Updated sorting logic in getSortedPspList function:

List of changes proposed in this pull request

  • Updated sorting logic in getSortedPspList function

How to test

  • Tap in Inquadra and try to pay something
  • Select a payment method
  • Check PSP bundles list
  • Tap on Ordina
  • Tap on a radio button to select a sorting option, then verify that the list is sorted correctly according to the chosen algorithm

Preview

Screen.Recording.2024-11-06.at.17.12.02.mov

@pagopa-github-bot pagopa-github-bot changed the title refactor: [IOBP-833] Sorting algorithms for PSP bundles chore: [IOBP-833] Sorting algorithms for PSP bundles Nov 7, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 7, 2024

Affected stories

  • ⚙️ IOBP-833: [Improvement] Adeguamento a nuove logiche di ordinamento GEC
    subtask of
    • IOBP-701: Evolutive flusso di on-boarding/pagamento

Generated by 🚫 dangerJS against e09e78b

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.88%. Comparing base (4f204b4) to head (27ec4de).
Report is 833 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6382      +/-   ##
==========================================
+ Coverage   48.42%   48.88%   +0.46%     
==========================================
  Files        1488     1578      +90     
  Lines       31617    32264     +647     
  Branches     7669     7389     -280     
==========================================
+ Hits        15311    15773     +462     
- Misses      16238    16434     +196     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
...ents/checkout/components/WalletPspListSkeleton.tsx 100.00% <100.00%> (+66.66%) ⬆️
.../payments/checkout/hooks/useSortPspBottomSheet.tsx 100.00% <100.00%> (+88.88%) ⬆️
...ts/checkout/screens/WalletPaymentPickPspScreen.tsx 89.23% <100.00%> (+85.45%) ⬆️
...features/payments/checkout/store/reducers/index.ts 85.71% <100.00%> (+70.00%) ⬆️
ts/features/payments/common/utils/index.ts 97.40% <100.00%> (+57.74%) ⬆️

... and 1712 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d971104...27ec4de. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants