Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1734] Add "back to top" in the wallet home screen #6491

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

mastro993
Copy link
Contributor

Short description

This PR adds the ability to return to the top of the wallet screen when tapping on the wallet tab navigation icon

List of changes proposed in this pull request

  • Added useTabItemPressWhenScreenActive handler in WalletHomeScreen

How to test

Navigate to the Wallet home screen, scroll to the bottom, tap on the tab navigation icon and check that the scroll view scrolls back to the top

Preview

RPReplay_Final1733305813.MP4

@mastro993 mastro993 self-assigned this Dec 4, 2024
@pagopa-github-bot pagopa-github-bot changed the title [SIW-1734] Add "back to top" when tapping on the wallet tab navigation icon fix(IT Wallet): [SIW-1734] Add "back to top" when tapping on the wallet tab navigation icon Dec 4, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 4, 2024

Affected stories

  • 🐞 SIW-1734: Tap su sez. Portafoglio > back to top

Generated by 🚫 dangerJS against 69c4a74

@mastro993 mastro993 changed the title fix(IT Wallet): [SIW-1734] Add "back to top" when tapping on the wallet tab navigation icon fix(IT Wallet): [SIW-1734] Add "back to top" in the wallet home screen Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.30%. Comparing base (4f204b4) to head (69c4a74).
Report is 830 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/wallet/screens/WalletHomeScreen.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6491      +/-   ##
==========================================
- Coverage   48.42%   48.30%   -0.13%     
==========================================
  Files        1488     1578      +90     
  Lines       31617    32265     +648     
  Branches     7669     7389     -280     
==========================================
+ Hits        15311    15585     +274     
- Misses      16238    16625     +387     
+ Partials       68       55      -13     
Files with missing lines Coverage Δ
ts/features/wallet/screens/WalletHomeScreen.tsx 80.64% <50.00%> (ø)

... and 1715 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2767743...69c4a74. Read the comment docs.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit 2fbaa6c into master Dec 4, 2024
10 checks passed
@mastro993 mastro993 deleted the SIW-1734-add-back-to-top-to-wallet-screen branch December 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants