Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-1047] Add store review when a payment is completed #6496

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Dec 4, 2024

Short description

This PR adds the store review request when a payment is completed.

List of changes proposed in this pull request

  • Invoked the API to request a store review when the payment outcome is completed and SUCCESS.

How to test

Start a payment flow with the dev-server and simulate a successful outcome from the in-app browser dropdown list. After that, check that the request to leave a review on the store dialog appears.

Preview

preview.mov

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 4, 2024

Affected stories

  • 🌟 IOBP-1047: [Recensioni store] Inserimento recensione a valle di un pagamento avvenuto con successo
    subtask of
    • IOBP-701: Evolutive flusso di on-boarding/pagamento

Generated by 🚫 dangerJS against c8999b1

…payment-completed' into IOBP-1047-add-store-review-when-payment-completed
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.30%. Comparing base (4f204b4) to head (c8999b1).
Report is 835 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6496      +/-   ##
==========================================
- Coverage   48.42%   48.30%   -0.12%     
==========================================
  Files        1488     1578      +90     
  Lines       31617    32268     +651     
  Branches     7669     7389     -280     
==========================================
+ Hits        15311    15588     +277     
- Misses      16238    16638     +400     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 85.18% <100.00%> (+83.62%) ⬆️

... and 1718 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c963455...c8999b1. Read the comment docs.

@LeleDallas
Copy link
Contributor

It works as expected on iOS 💫!

Is it normal that the rating form isn't displayed on Android🤔?

Screen.Recording.2024-12-04.at.13.14.43.mov

@Hantex9
Copy link
Contributor Author

Hantex9 commented Dec 4, 2024

It works as expected on iOS 💫!

Is it normal that the rating form isn't displayed on Android🤔?

Screen.Recording.2024-12-04.at.13.14.43.mov

Could you test it on a real android device?

@LeleDallas
Copy link
Contributor

It works as expected on iOS 💫!
Is it normal that the rating form isn't displayed on Android🤔?
Screen.Recording.2024-12-04.at.13.14.43.mov

Could you test it on a real android device?

That's a real android device😅
I used scrcpy for display purpose

@LeleDallas
Copy link
Contributor

It works as expected on iOS 💫!
Is it normal that the rating form isn't displayed on Android🤔?
Screen.Recording.2024-12-04.at.13.14.43.mov

Could you test it on a real android device?

That's a real android device😅 I used scrcpy for display purpose

Nvm, the device I used was not logged with a google account into GooglePlay

Works as expected!

Screenshot 2024-12-04 at 14 55 00

@Hantex9
Copy link
Contributor Author

Hantex9 commented Dec 5, 2024

There has been a change in requirements, and it has been decided to move the request for a store review to when the user closes the thank-you page.

Preview

preview.mov

@Hantex9 Hantex9 merged commit a8e32df into master Dec 5, 2024
12 checks passed
@Hantex9 Hantex9 deleted the IOBP-1047-add-store-review-when-payment-completed branch December 5, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants