-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOBP-1047] Add store review when a payment is completed #6496
feat: [IOBP-1047] Add store review when a payment is completed #6496
Conversation
…payment-completed' into IOBP-1047-add-store-review-when-payment-completed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6496 +/- ##
==========================================
- Coverage 48.42% 48.30% -0.12%
==========================================
Files 1488 1578 +90
Lines 31617 32268 +651
Branches 7669 7389 -280
==========================================
+ Hits 15311 15588 +277
- Misses 16238 16638 +400
+ Partials 68 42 -26
... and 1718 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
It works as expected on iOS 💫! Is it normal that the rating form isn't displayed on Android🤔? Screen.Recording.2024-12-04.at.13.14.43.mov |
Could you test it on a real android device? |
That's a real android device😅 |
…payment-completed' into IOBP-1047-add-store-review-when-payment-completed
There has been a change in requirements, and it has been decided to move the request for a store review to when the user closes the thank-you page. Previewpreview.mov |
Short description
This PR adds the store review request when a payment is completed.
List of changes proposed in this pull request
How to test
Start a payment flow with the dev-server and simulate a successful outcome from the in-app browser dropdown list. After that, check that the request to leave a review on the store dialog appears.
Preview
preview.mov