Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOCOM-1949] FIMS iossoapi protocol #6505

Merged
merged 4 commits into from
Dec 5, 2024
Merged

chore: [IOCOM-1949] FIMS iossoapi protocol #6505

merged 4 commits into from
Dec 5, 2024

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR adds support for iossoapi protocol when using the InApp Browser on FIMS

List of changes proposed in this pull request

  • latest react-native-login-utils library
  • iossoapi protocol added to the InApp Browser callback

How to test

Using the related io-dev-api-server, check that the InApp Browser from FIMS is closeable using the related web page button.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1949] FIMS iossoapi protocol chore: [IOCOM-1949] FIMS iossoapi protocol Dec 4, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 4, 2024

Affected stories

  • ⚙️ IOCOM-1949: [FIMS] Valutazione della chiusura In-App-Browser con link/procedura programmatica
    subtask of
    • IOCOM-2007: FIMS: Gestione RP interni a PagoPA

Generated by 🚫 dangerJS against 0fe352e

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.30%. Comparing base (4f204b4) to head (0fe352e).
Report is 834 commits behind head on master.

Files with missing lines Patch % Lines
...eSignOn/saga/handleFimsGetRedirectUrlAndOpenIAB.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6505      +/-   ##
==========================================
- Coverage   48.42%   48.30%   -0.13%     
==========================================
  Files        1488     1578      +90     
  Lines       31617    32265     +648     
  Branches     7669     7342     -327     
==========================================
+ Hits        15311    15585     +274     
- Misses      16238    16638     +400     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
...eSignOn/saga/handleFimsGetRedirectUrlAndOpenIAB.ts 4.41% <0.00%> (ø)

... and 1718 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d971104...0fe352e. Read the comment docs.

Copy link
Member

@adelloste adelloste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS simulator and everything works as expected. However, after the bundle exec pod install command, my Podfile.lock file changed. Should it be updated?

@Vangaorth
Copy link
Contributor Author

Tested on iOS simulator and everything works as expected. However, after the bundle exec pod install command, my Podfile.lock file changed. Should it be updated?

You are absolutely right. Updated

Copy link
Member

@adelloste adelloste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth merged commit c963455 into master Dec 5, 2024
12 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1949 branch December 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants