-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOCOM-1949] FIMS iossoapi
protocol
#6505
Conversation
iossoapi
protocoliossoapi
protocol
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6505 +/- ##
==========================================
- Coverage 48.42% 48.30% -0.13%
==========================================
Files 1488 1578 +90
Lines 31617 32265 +648
Branches 7669 7342 -327
==========================================
+ Hits 15311 15585 +274
- Misses 16238 16638 +400
+ Partials 68 42 -26
... and 1718 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS simulator and everything works as expected. However, after the bundle exec pod install
command, my Podfile.lock
file changed. Should it be updated?
You are absolutely right. Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR adds support for
iossoapi
protocol when using the InApp Browser on FIMSList of changes proposed in this pull request
iossoapi
protocol added to the InApp Browser callbackHow to test
Using the related io-dev-api-server, check that the InApp Browser from FIMS is closeable using the related web page button.