-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1927] Add pull-to-refresh to the wallet screen #6556
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6556 +/- ##
==========================================
+ Coverage 48.42% 49.25% +0.82%
==========================================
Files 1488 1553 +65
Lines 31617 31983 +366
Branches 7669 7240 -429
==========================================
+ Hits 15311 15752 +441
+ Misses 16238 16192 -46
+ Partials 68 39 -29
... and 1729 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1927 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR enables the "pull to refresh" feature in the wallet home screen.
List of changes proposed in this pull request
IOScrollView
component, which was causing the RefreshIndicator to ne be displayed correctly. See more here: ScrollView: RefreshControl not visible during refreshing if snapToOffsets is used. facebook/react-native#27324 (cc @dmnplb)WalletHomeScreen
removing unnecessary extra componentswatchWalletSaga
to dedicatedhandleWalletAnalyticsSaga
walletUpdate
action, handled byhandleWalletUpdateSaga
, which updates the wallet contentwatchWalletSaga
handler and wallet reducer: placeholders are no more replacing existing cards with the same keyisWalletScreenRefreshingSelector
selector, to get the wallet refresh stateHow to test
Navigate to the wallet screen, try to "pull to refresh" and see if the content is being updated/refreshed and the refresh indicator works as expected.
Demo
RPReplay_Final1734428052.MP4