-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1937] Improve wallet category filters #6570
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1937 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6570 +/- ##
==========================================
+ Coverage 42.85% 49.30% +6.44%
==========================================
Files 1408 1555 +147
Lines 29557 32117 +2560
Branches 6659 7267 +608
==========================================
+ Hits 12668 15834 +3166
+ Misses 16860 16245 -615
- Partials 29 38 +9
... and 349 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR fixes a bug in the wallet screen where users were unable to see any screen content if the category filters were in the wrong state. This PR also improves the debug data overlay and the wallet redux selectors.
Steps to reproduce the addressed bug
List of changes proposed in this pull request
isWalletCategoryFilteringEnabledSelector
selector to check if the category filtering is available: filtering is available only if there is more than one category in the wallet.shouldRenderWalletCategorySelector
selector to check if a wallet category section should be rendered, based on the currently selected filter and the number of categories available in the walletwithWalletCategoryFilter
HOC, which display a component based on the given category filterselectWalletCardsByCategory
andselectWalletCardsByType
to select cards based on category or type, removing the need to have dedicated selectorsselectWalletCgnCard
andselectBonusCards
selectorsDebugInfoOverlay
Set
objectsWalletCardsContainer
with new selectorscategoryFilter
preference persistence from thewallet.preferences
feature reducerHow to test