Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix agent for both HTTP/HTTPS support #208

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix agent for both HTTP/HTTPS support #208

merged 1 commit into from
Jan 3, 2023

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Jan 3, 2023

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@AleDore AleDore requested a review from a team as a code owner January 3, 2023 14:33
@AleDore AleDore requested review from Garma00 and gquadrati and removed request for a team January 3, 2023 14:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

BurnedMarshal
BurnedMarshal approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleDore AleDore merged commit ad4642c into master Jan 3, 2023
@AleDore AleDore deleted the fix-fetch-agent branch January 3, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 is a code owner automatically assigned from pagopa/io-backend-contributors

@gquadrati gquadrati Awaiting requested review from gquadrati gquadrati is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AleDore @pagopa-github-bot @BurnedMarshal