Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPAE-203] Add UpdateSubscriptionCidrs #218

Merged
merged 8 commits into from
Mar 14, 2023
Merged

[#IOPAE-203] Add UpdateSubscriptionCidrs #218

merged 8 commits into from
Mar 14, 2023

Conversation

giuseppedipinto
Copy link
Contributor

@giuseppedipinto giuseppedipinto commented Mar 10, 2023 •
edited
Loading

We add new UpdateSubscriptionCidrs admin API in order to update subscription authtorized_cidrs.

List of Changes

  • add UpdateSubscriptionCidrs
  • update openapi specification
  • update package.json

Motivation and Context

We need to limit the use of Manage Subscription key to an authorized IP List (in CIDRs format).

How Has This Been Tested?

Unit Tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giuseppedipinto giuseppedipinto requested a review from a team as a code owner March 10, 2023 10:52
@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-203

balanza
balanza suggested changes Mar 13, 2023
View reviewed changes
UpdateSubscriptionCidrs/handler.ts Outdated Show resolved Hide resolved
UpdateSubscriptionCidrs/handler.ts Show resolved Hide resolved
GetSubscription/handler.ts Outdated Show resolved Hide resolved
GetSubscription/handler.ts Outdated Show resolved Hide resolved
@balanza balanza self-requested a review March 13, 2023 16:39
@giuseppedipinto giuseppedipinto changed the title [#IOPAE-203] Update GetSubscription and Add UpdateSubscriptionCidrs [#IOPAE-203] Add UpdateSubscriptionCidrs Mar 14, 2023
@giuseppedipinto giuseppedipinto requested a review from balanza March 14, 2023 10:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@giuseppedipinto giuseppedipinto merged commit 711b82b into master Mar 14, 2023
@giuseppedipinto giuseppedipinto deleted the IOPAE-203--update-subscription-with-cidrs branch March 14, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balanza balanza balanza approved these changes

@rodoviti rodoviti Awaiting requested review from rodoviti

@LoFrance LoFrance Awaiting requested review from LoFrance

@StefanoDoc StefanoDoc Awaiting requested review from StefanoDoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuseppedipinto @balanza