[#171549246] Add function to create a new user #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunzip
requested changes
Mar 12, 2020
CreateUser/handler.ts
Outdated
| toError | ||
| ).map( | ||
| credentials => | ||
| // the below cast to `any` is needed to prevent build errors |
There was a problem hiding this comment.
this should be solved using 4.x version of azure graph package:
https://github.com/gunzip/adb2c-apim-migrate/blob/master/package.json#L8
openapi/index.yaml
Outdated
| @@ -280,6 +280,26 @@ paths: | |||
| description: List of users | |||
| schema: | |||
| $ref: "#/definitions/UserCollection" | |||
| post: | |||
| summary: Create user | |||
| description: Create a new User with a random password on the Active Directory Azure B2C and create the corresponding User on the APIM. | |||
There was a problem hiding this comment.
Suggested change
| description: Create a new User with a random password on the Active Directory Azure B2C and create the corresponding User on the APIM. | |
| description: Create a new user with a random password in the Active Directory Azure B2C, then create a corresponding user on the API management resource. |
README.md
Outdated
| @@ -19,6 +19,9 @@ they may be customized as needed. | |||
| | SERVICE_PRINCIPAL_CLIENT_ID | The service principal name used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_SECRET | The service principal secret used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_TENANT_ID | The service principal tenant id used to get the token credentials to connect to the APIM | string | | |||
| | ADB2C_CLIENT_ID | The service principal name used to get the token credentials to connect to the ADB2C | string | | |||
There was a problem hiding this comment.
these are parameters relative to an application registered into the ADB2C tenant
README.md
Outdated
| @@ -19,6 +19,9 @@ they may be customized as needed. | |||
| | SERVICE_PRINCIPAL_CLIENT_ID | The service principal name used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_SECRET | The service principal secret used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_TENANT_ID | The service principal tenant id used to get the token credentials to connect to the APIM | string | | |||
| | ADB2C_CLIENT_ID | The service principal name used to get the token credentials to connect to the ADB2C | string | | |||
There was a problem hiding this comment.
Suggested change
| | ADB2C_CLIENT_ID | The service principal name used to get the token credentials to connect to the ADB2C | string | | |
| | ADB2C_CLIENT_ID | The application client id used to get the token credentials to connect to the ADB2C | string | |
README.md
Outdated
| @@ -19,6 +19,9 @@ they may be customized as needed. | |||
| | SERVICE_PRINCIPAL_CLIENT_ID | The service principal name used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_SECRET | The service principal secret used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_TENANT_ID | The service principal tenant id used to get the token credentials to connect to the APIM | string | | |||
| | ADB2C_CLIENT_ID | The service principal name used to get the token credentials to connect to the ADB2C | string | | |||
| | ADB2C_CLIENT_KEY | The service principal secret used to get the token credentials to connect to the ADB2C | string | | |||
There was a problem hiding this comment.
Suggested change
| | ADB2C_CLIENT_KEY | The service principal secret used to get the token credentials to connect to the ADB2C | string | | |
| | ADB2C_CLIENT_KEY | The application secret used to get the token credentials to connect to the ADB2C | string | |
README.md
Outdated
| @@ -19,6 +19,9 @@ they may be customized as needed. | |||
| | SERVICE_PRINCIPAL_CLIENT_ID | The service principal name used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_SECRET | The service principal secret used to get the token credentials to connect to the APIM | string | | |||
| | SERVICE_PRINCIPAL_TENANT_ID | The service principal tenant id used to get the token credentials to connect to the APIM | string | | |||
| | ADB2C_CLIENT_ID | The service principal name used to get the token credentials to connect to the ADB2C | string | | |||
| | ADB2C_CLIENT_KEY | The service principal secret used to get the token credentials to connect to the ADB2C | string | | |||
| | ADB2C_TENANT_ID | The service principal tenant id used to get the token credentials to connect to the ADB2C | string | | |||
There was a problem hiding this comment.
Suggested change
| | ADB2C_TENANT_ID | The service principal tenant id used to get the token credentials to connect to the ADB2C | string | | |
| | ADB2C_TENANT_ID | The ADB2C tenant id | string | |
CreateUser/handler.ts
Outdated
| .chain(userCreateResponse => | ||
| getApiClient(apimCredentials, azureApimConfig.subscriptionId) | ||
| .mapLeft(error => | ||
| internalErrorHandler("Could not get the APIM client", error) |
There was a problem hiding this comment.
Suggested change
| internalErrorHandler("Could not get the APIM client", error) | |
| internalErrorHandler("Could not get the API management client", error) |
CreateUser/handler.ts
Outdated
| taskResults.apimClient.user.createOrUpdate( | ||
| azureApimConfig.apimResourceGroup, | ||
| azureApimConfig.apim, | ||
| taskResults.userId, |
There was a problem hiding this comment.
``
Suggested change
| taskResults.userId, | |
| taskResults.objectId, |
| azureApimConfig.apimResourceGroup, | ||
| azureApimConfig.apim, | ||
| taskResults.userId, | ||
| { |
There was a problem hiding this comment.
you must link the adb2c identity to the one generated into the adb2c, see this code:
https://github.com/gunzip/adb2c-apim-migrate/blob/master/migrate.ts#L280
gunzip
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to create a User on the Active Directory Azure B2C and on the API Management.