Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pre-commit docs and terraform version #367

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

diegolagospagopa
Copy link
Contributor

@diegolagospagopa diegolagospagopa commented Oct 28, 2024

List of changes

  • terraform version is 1.7.3
  • pre-commit is v1.86.1 (that includes tf 1.7.3)

Motivation and context

Terraform version and pre-commit was not aligned, to every time pre-commit static analysis failed because it generates different README.

Type of changes

  • Add new module
  • Update existing module
  • Remove existing module
  • Other changes

Does this introduce a breaking change?

  • Yes
  • No

Other information

Run checks

Useful commands to run checks on local machine

bash .utils/terraform_run_all.sh init local
pre-commit run -a

@diegolagospagopa diegolagospagopa requested review from a team as code owners October 28, 2024 09:10
@diegolagospagopa diegolagospagopa changed the title fix: pre-commit README generated fix: pre-commit docs and terraform version Oct 28, 2024
@diegolagospagopa diegolagospagopa merged commit c034ec1 into main Oct 28, 2024
6 checks passed
@diegolagospagopa diegolagospagopa deleted the fix-precommit branch October 28, 2024 11:25
Copy link

🎉 This PR is included in version 8.52.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant