Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution delay ignored for actions inside a loop #69

Closed
ghost opened this issue May 13, 2022 · 2 comments
Closed

Execution delay ignored for actions inside a loop #69

ghost opened this issue May 13, 2022 · 2 comments

Comments

@ghost
Copy link

ghost commented May 13, 2022

How to reproduce:

  1. Add 3 actions inside a loop and make them execute in async mode
  2. Set execution delay to 1000ms for second and third action
  3. Set loop iteration delay to 3000ms

What happens:

The three actions are executed one after the other in quick succession with 3s delay in between loops.

Expected result:

The first action is run immediately, the second action is run 1000ms after execution of first one, the third action is run 1000ms after execution of the second one and the loop starts again 1000ms after end of third action.

Trigger sample showcasing the issue:

<?xml version="1.0"?>
<TriggernometryExport Version="1">
  <ExportedFolder Id="3f4528f6-88e5-46cb-a041-a3b3a4ef5f9b" Name="loop" Enabled="true">
    <Folders />
    <Triggers>
      <Trigger Enabled="true" Sequential="True" Name="Start" Id="1c4d5355-7612-4f9d-ad68-027c0e039dc7" RegularExpression="">
        <Actions>
          <Action OrderNumber="1" OBSEndPoint="" VariableOp="SetString" VariableName="looptest" VariableExpression="true" TextAuraFontSize="8.25" TextAuraFontName="Microsoft Sans Serif" ActionType="Variable">
            <Condition Enabled="false" Grouping="Or" />
          </Action>
          <Action OrderNumber="2" LoopDelayExpression="3000" OBSEndPoint="" TextAuraFontSize="8.25" TextAuraFontName="Microsoft Sans Serif" ActionType="Loop">
            <LoopCondition Enabled="true" Grouping="Or">
              <ConditionSingle Enabled="true" ExpressionL="${evar:looptest}" ExpressionTypeL="Numeric" ExpressionR="1" ExpressionTypeR="Numeric" ConditionType="NumericEqual" />
            </LoopCondition>
            <LoopActions>
              <Action OrderNumber="1" OBSEndPoint="" TextAuraFontSize="8.25" TextAuraFontName="Microsoft Sans Serif" ActionType="SystemBeep" Asynchronous="False">
                <Condition Enabled="false" Grouping="Or" />
              </Action>
              <Action OrderNumber="2" OBSEndPoint="" TextAuraFontSize="8.25" TextAuraFontName="Microsoft Sans Serif" ActionType="SystemBeep" ExecutionDelayExpression="1000" Asynchronous="False">
                <Condition Enabled="false" Grouping="Or" />
              </Action>
              <Action OrderNumber="3" OBSEndPoint="" TextAuraFontSize="8.25" TextAuraFontName="Microsoft Sans Serif" ActionType="SystemBeep" ExecutionDelayExpression="1000" Asynchronous="False">
                <Condition Enabled="false" Grouping="Or" />
              </Action>
            </LoopActions>
            <Condition Enabled="false" Grouping="Or" />
          </Action>
        </Actions>
        <Condition Enabled="false" Grouping="Or" />
        <Conditions />
      </Trigger>
      <Trigger Enabled="true" Name="Stop" Id="a8558c4a-d826-4fd6-891f-d1d7f93490e5" RegularExpression="">
        <Actions>
          <Action OrderNumber="1" OBSEndPoint="" VariableName="looptest" TextAuraFontSize="8.25" TextAuraFontName="Microsoft Sans Serif" ActionType="Variable">
            <Condition Enabled="false" Grouping="Or" />
          </Action>
        </Actions>
        <Condition Enabled="false" Grouping="Or" />
        <Conditions />
      </Trigger>
    </Triggers>
  </ExportedFolder>
</TriggernometryExport>
@KingPendragoon
Copy link

Loops also ignore checkmark for on or off and always fire

@paissaheavyindustries
Copy link
Owner

should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants