Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude/Preserve lines when stamp_changelog #22

Closed
Blackjacx opened this issue Sep 7, 2017 · 5 comments
Closed

Exclude/Preserve lines when stamp_changelog #22

Blackjacx opened this issue Sep 7, 2017 · 5 comments
Assignees
Labels

Comments

@Blackjacx
Copy link

I setup the changelog plugin of the gem danger which enforces a certain changelog style which is very suitable. But it forces me to keep the line * Your contribution here. directly under the ## [Unreleased] section of my changelog. This is very good so contributer know where to add new changes. On the other hand I

  1. Don't want to exclude this line from my changelog of a certain version when I call stamp_changelog
  2. I want to preserve this line in my ## [Unreleased] section when I call stamp_changelog

I propose to add the option to Exclude a certain text when stamping a changelog version and preserve this exact text in the unreleased section.

@pajapro
Copy link
Owner

pajapro commented Nov 18, 2017

Hey @Blackjacx,

thanks for bringing up this feature request - I think this could be useful to many others.

I have implemented it, but would like you to review my PR before I merge & release this functionality #26.

Looking forward to your feedback

@Blackjacx
Copy link
Author

Blackjacx commented Nov 20, 2017

Sorry for the comment before. It just works!!! Thank you very much :-)

@Blackjacx
Copy link
Author

When can you release this fix?

@pajapro
Copy link
Owner

pajapro commented Nov 25, 2017

Hey @Blackjacx, this feature is release now in version 0.9.0 - enjoy 🎉

@pajapro pajapro closed this as completed Nov 25, 2017
@Blackjacx
Copy link
Author

Blackjacx commented Nov 25, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants