Should we add integration tests to this repository?

[robdimsdale]

I was surprised to not see any integration tests in this library. I'd like to start a conversation about adding them. I haven't seen any existing conversation in the issues for this repository, so it doesn't look like this conversation has been had before.

This library is a wrapper around the docker client / CLI, and there are places where we decode json into our custom definitions (e.g. Inspect). However, there are no integration tests validating this structure, which means we don't actually have confidence this library is performing correctly.

In practice, one can iterate on changes to this library by utilizing them in a consumer (e.g. a buildpack's integration tests) but that is less clear (and more effort) than self-contained integration tests in this library.

What do folks think? Any strong objections to integration tests?

[garethjevans]

I think that a basic set of integration tests would be a good addition to this repository. They could be used as a set of living examples of how best to use occam