Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal should support setting classname on .pt-portal element #1007

Closed
adidahiya opened this issue Apr 18, 2017 · 8 comments
Closed

Portal should support setting classname on .pt-portal element #1007

adidahiya opened this issue Apr 18, 2017 · 8 comments

Comments

@adidahiya
Copy link
Contributor

can't change the behavior of portalClassName, so this will have to be a new prop that deprecates that one

@giladgray
Copy link
Contributor

portalContainerClassName?

@giladgray
Copy link
Contributor

moving where portalClassName gets applied up one element in the tree would be a mild API break, yeah?

@adidahiya
Copy link
Contributor Author

yeah, that would be an API break. can't do that in 1.x. portalContainerClassName sounds good

@dserrano-geo
Copy link

Hi.

I'm trying to organize the portals by z-index, but this is not possible with the portalClassName property, because portalClassName is inside from .pt-portal div. Is there a way to apply changes on demand in the .pt-portal class of each div?

Regards.

@adidahiya
Copy link
Contributor Author

No, you shouldn't have to control z-index of popovers. Why do you need to do this? Do you have multiple popovers open at once?

@dserrano-geo
Copy link

We have a group of buttons that have tooltips, when you click, a popover is displayed with a component. While the popover is displayed, the tooltips are below the popover, we need the tooltips always to be above, because that's what the design requires. We are looking for ways to handle this.

@giladgray giladgray added this to the 2.0.0 milestone Mar 16, 2018
@giladgray
Copy link
Contributor

fixed in #2205

@giladgray
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants