Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Do we need loading states on ghost header cells? #1230

Open
cmslewis opened this issue Jun 13, 2017 · 6 comments
Open

[Table] Do we need loading states on ghost header cells? #1230

cmslewis opened this issue Jun 13, 2017 · 6 comments

Comments

@cmslewis
Copy link
Contributor

cmslewis commented Jun 13, 2017

Bug report

  • Package version(s): v1.20.0

Steps to reproduce

  1. Enable loading for column header cells.

Actual behavior

Ghost header cells have loading bars.

image

Expected behavior

Maybe don't have loading bars on ghost cells?

@cmslewis
Copy link
Contributor Author

// CC @tgreenwatts

@llorca
Copy link
Contributor

llorca commented Jun 13, 2017

Why wouldn't you? Loading bars are helpful anywhere data can be loaded, which applies to both body cells and column headers. We also do it for rows because we can't know for sure the number of rows before loading

@cmslewis
Copy link
Contributor Author

@llorca Ah yeah, makes sense if the table dimensions aren't known yet. I'll close.

@tgreenwatts
Copy link
Contributor

Wait but what if we do know the number of columns already? Doesn't this example show that we know how many columns we have, so we shouldn't pretend we're going to load other columns?

@llorca
Copy link
Contributor

llorca commented Jun 13, 2017

You might know the number of columns while not knowing the content of those columns, in which case you'll still need a loading state

@tgreenwatts
Copy link
Contributor

Cool clarified offline
If you know the number of columns, only show loading state for the columns you know are going to load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants