Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift + ? does not dismiss hotkeys dialogs #1238

Closed
michael-yx-wu opened this issue Jun 14, 2017 · 5 comments
Closed

Shift + ? does not dismiss hotkeys dialogs #1238

michael-yx-wu opened this issue Jun 14, 2017 · 5 comments

Comments

@michael-yx-wu
Copy link
Contributor

Shift + ? shows the hotkeys dialog but does not dismiss it.

From @gjavitt:

shift + ? should dismiss, but there should also be a pt-icon-cross in the top right or a dismiss button, probably the former

@llorca
Copy link
Contributor

llorca commented Jun 14, 2017

Wouldn't mind shift+? acting as a toggle. Cross / dismiss button aren't necessary as you can already either press esc or click outside

@gjavitt
Copy link
Contributor

gjavitt commented Jun 14, 2017

Does clicking on the backdrop also dismiss?
I was worried about less technical users getting stuck here and not figuring out how to dismiss it. Have met users who don't use their keyboards if they can avoid it.

@llorca
Copy link
Contributor

llorca commented Jun 14, 2017

Yes, that's what I meant by "clicking outside", i.e. clicking on the backdrop

@gjavitt
Copy link
Contributor

gjavitt commented Jun 14, 2017

Ah, misread. sgtm

@cmslewis cmslewis self-assigned this Jun 29, 2017
@cmslewis
Copy link
Contributor

Taking a look at this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants