Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No abbility to ContextMenu.show after modal dialog #2131

Closed
avin opened this issue Feb 14, 2018 · 5 comments · Fixed by #2399
Closed

No abbility to ContextMenu.show after modal dialog #2131

avin opened this issue Feb 14, 2018 · 5 comments · Fixed by #2399

Comments

@avin
Copy link

avin commented Feb 14, 2018

As ContextMenu.show uses single DOM element, if modal popover made after first time ContextMenu.show - new menu is behind modal dialog popover.

@giladgray
Copy link
Contributor

giladgray commented Feb 14, 2018

this behavior is most certainly intentional, and kind of par for the course. overlays open in a stack simply due to DOM ordering, so if you open a Dialog over a Popover (context menu), it's going to cover it.

@adidahiya
Copy link
Contributor

what if you want to show a context menu on an item in a Dialog?

@avin
Copy link
Author

avin commented Feb 14, 2018

have to use dirty hack with setup z-index on selector .pt-context-menu + .pt-portal

@adidahiya
Copy link
Contributor

not sure how my comment got deleted, but I'm pretty sure the issue is here, where we only ever create the context menu portal container element once per instance of blueprint:

document.body.appendChild(contextMenuElement);

@adidahiya adidahiya reopened this Feb 14, 2018
@giladgray
Copy link
Contributor

oh ok that's reasonable. we can make a new element each time.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants