Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control-group element borders don't necessarily align in dark theme #233

Closed
cmslewis opened this issue Nov 24, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@cmslewis
Copy link
Contributor

Bug Report

  • Package version(s): v1.1.0
  • Browser and OS versions: Chrome 54.0.2840.71 (64-bit) on OS X 10.11.6

Describe the issue:

In the dark theme, intent-ful control group elements don't necessarily have aligned borders. See this example from the numeric stepper:

image

Actual behavior:

Note that the red input-field border doesn't align with the red buttons' edges.

Expected behavior:

Would be nice if they did align. Sort of a tricky case though.

@cmslewis cmslewis changed the title Control group element borders don't necessarily align in dark theme Control-group element borders don't necessarily align in dark theme Nov 24, 2016
@cmslewis
Copy link
Contributor Author

@llorca would love your thoughts here

@llorca
Copy link
Contributor

llorca commented Nov 24, 2016

Good catch! I'll look into it, numerical stepper revealed a few visual bugs around dark theme control groups

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants