Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTime] Drop dependency on Icon fonts #2801

Closed
mrijke opened this issue Aug 14, 2018 · 3 comments
Closed

[DateTime] Drop dependency on Icon fonts #2801

mrijke opened this issue Aug 14, 2018 · 3 comments
Assignees
@giladgray
Labels
Package: datetime Type: enhancement

Comments

@mrijke
Copy link

mrijke commented Aug 14, 2018

Environment

  • Package version(s): @blueprintjs/datetime": "3.0.0"
  • Browser and OS versions: Chromium & Ubuntu 16.04

Feature request

The current implementation of the Date picker relies on the icon font for the previous and next month buttons and as far as I understood, icon fonts were considered legacy within this project. It would be nice to be able have SVG icons for those, or even better, be able to provide our own (for example, FontAwesome icons).
Thanks for your consideration!
@giladgray
Copy link
Contributor

@mrijke indeed it does and I actually have a fix for that open right now #2792

@giladgray giladgray self-assigned this Aug 14, 2018
@giladgray giladgray mentioned this issue Aug 14, 2018
Merged
@mrijke
Copy link
Author

mrijke commented Aug 15, 2018

@giladgray That's great news! I'll be monitoring that PR. Thanks for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giladgray giladgray

Labels
Package: datetime Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrijke @giladgray and others